This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Update application services to 0.48.0 - Xcode 11.3 #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds on buddybuild are currently failing because Glean needs to be updated to build with the newest version of Xcode and Swift. There should be a new release with this update in the next day or two. Glean team ticket here: https://bugzilla.mozilla.org/show_bug.cgi?id=1607593 |
jhugman
approved these changes
Jan 13, 2020
Shared/Store/BaseDataStore.swift
Outdated
| if let url = FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: sharedContainerIdentifier) { | ||
| rootPath = url.path | ||
| guard let loginsDatabasePath = loginsDatabasePath else { return } | ||
| setupSalt() |
There was a problem hiding this comment.
Nit: my preference would be to have setupSalt() return a string, and assignment happen here.
e.g.
self.salt = findSalt()
Shared/Store/BaseDataStore.swift
Outdated
| } else { | ||
| print("Unable to find the shared container. Defaulting profile location to ~/Documents instead.") | ||
| rootPath = (NSSearchPathForDirectoriesInDomains(.documentDirectory, .userDomainMask, true)[0]) | ||
| salt = setupPlaintextHeaderAndGetSalt(databasePath: loginsDatabasePath, encryptionKey: loginsKey) |
There was a problem hiding this comment.
Nit: similarly, this naming could do with some work:
salt = createNewSalt(databasePath: loginsDatabasePath, encryptionKey: loginsKey) 
…date app services to 0.48.3. Move initFxa() to background thread to prevent blocking the main queue.
…running test versions of the app and then downgrading to the store version
jhugman
approved these changes
Feb 6, 2020
kaylagalway
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1176
Fixes #1170
Fixes #955
Updates Application Services to v0.48.3
Updates Glean to v23.0.1
Updates Lockwise to Xcode 11.3
Makes database plain text header and salt changes necessary to resolve Credential Provider Crashes - Autofill #1170 as discussed in App Services Issue 2100
Referenced Garvan's changes in Firefox iOS: Fix #5974: sql cipher plaintext header and salt mozilla-mobile/firefox-ios#5990
Fixes issue where when lockwise app is deleted and then reinstalled, user automatically gets logged in. Added keychain clearing at an earlier stage of startup to resolve this and resolve issues it caused with old database salts being stored.